[PATCH] Enhance time sampling of async IO VFS functions

Jeremy Allison jra at samba.org
Sun Feb 28 16:39:19 UTC 2016


On Sun, Feb 28, 2016 at 11:28:06AM +0100, Volker Lendecke wrote:
> On Fri, Feb 26, 2016 at 09:56:58PM +0100, Ralph Boehme wrote:
> > On Fri, Feb 26, 2016 at 10:45:31AM -0800, Jeremy Allison wrote:
> > > On Fri, Feb 26, 2016 at 06:39:36PM +0100, Ralph Boehme wrote:
> > > > I though about adding struct tevent_req.async.(uint64_t)duration and
> > > > getter/setter functions
> > > > tevent_req_set_duration()/tevent_req_get_duration().
> > > > 
> > > > This could then be used by the implementation of an async request to
> > > > set the duration and the caller can read it, further passing up the
> > > > stack and processing as needed.
> > > 
> > > If we want to make this a generic feature of tevent, then
> > > the above is the way to go - but I think that needs a bigger
> > > discussion than just you and I.
> > > 
> > > Metze, Volker - what do you think about adding duration
> > > as a feature to tevent_req.async ?
> > 
> > something like this.
> 
> Is it theoretically possible to implement this feature without modifying
> tevent, just within asys.c? Apologies for not coming up with a polished
> proposal mself, but I would like to avoid bloat in such a central
> structure if possible.

Sure, if we change the param blocks to the smbd VFS aio
calls then we can do it only inside smbd.

I think the question Ralph had is more about if you
think this is worthwhile to add as a feature to tevent ?

Or did you just answer that question ? :-) :-).



More information about the samba-technical mailing list