[PATCH] Enhance time sampling of async IO VFS functions

Jeremy Allison jra at samba.org
Sun Feb 28 18:45:47 UTC 2016

On Sun, Feb 28, 2016 at 05:45:24PM +0100, Volker Lendecke wrote:
> On Sun, Feb 28, 2016 at 08:39:19AM -0800, Jeremy Allison wrote:
> > > Is it theoretically possible to implement this feature without modifying
> > > tevent, just within asys.c? Apologies for not coming up with a polished
> > > proposal mself, but I would like to avoid bloat in such a central
> > > structure if possible.
> > 
> > Sure, if we change the param blocks to the smbd VFS aio
> > calls then we can do it only inside smbd.
> > 
> > I think the question Ralph had is more about if you
> > think this is worthwhile to add as a feature to tevent ?
> > 
> > Or did you just answer that question ? :-) :-).
> Right now we have one case where someone really needs this feature. We
> have many cases that don't. So if there's an elegant way to do this
> without adding 8 bytes to struct tevent_req I'd prefer that.

I think that answers the question.

Ralph, I'm sorry - but can you re-do this by creating
a 'struct aiocb {... stuff...}' struct for the VFS
calls, so we don't have to keep adding extra params
if we need something new ?

I'm happy to review..

More information about the samba-technical mailing list