[PATCH] Reintroduce support for RPC modules

Ralph Boehme rb at sernet.de
Fri Feb 19 16:15:04 UTC 2016

On Fri, Feb 19, 2016 at 03:37:07PM +0100, Andreas Schneider wrote:
> On Friday 19 February 2016 13:39:47 Ralph Boehme wrote:
> > Hi!
> Hi Ralph,
> could you please fix a few things in the source code. Some functions are 
> inconsistent to others. See comments below.
> ...offendings against README.Coding...

arg, guilty. That part I copied&pasted and missed to update those
pieces. :)

> Also bool helper variables in that functions would not hurt.
> ==============
> In rpc_setup_embedded() please check return values of load_samba_modules() and 
> run_init_functions()

good catch, I'll fix that.

> With these changes you can push that code with my RB+.

Oh, thanks. I was already thinking about stronger arguments or
alternatives. :)


SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen

More information about the samba-technical mailing list