[PATCH] Reintroduce support for RPC modules

Ralph Boehme rb at sernet.de
Mon Feb 22 09:22:27 UTC 2016


On Fri, Feb 19, 2016 at 05:15:04PM +0100, Ralph Boehme wrote:
> On Fri, Feb 19, 2016 at 03:37:07PM +0100, Andreas Schneider wrote:
> > On Friday 19 February 2016 13:39:47 Ralph Boehme wrote:
> > > Hi!
> > 
> > Hi Ralph,
> > 
> > could you please fix a few things in the source code. Some functions are 
> > inconsistent to others. See comments below.
> >
> > ...offendings against README.Coding...
> 
> arg, guilty. That part I copied&pasted and missed to update those
> pieces. :)
> 
> > Also bool helper variables in that functions would not hurt.
> > 
> > ==============
> > 
> > In rpc_setup_embedded() please check return values of load_samba_modules() and 
> > run_init_functions()
> 
> good catch, I'll fix that.

pushed with those changes. Thanks again!

-Ralph

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de,mailto:kontakt@sernet.de



More information about the samba-technical mailing list