ctdb reclock API for etcd/librados
amitay at gmail.com
Wed Dec 7 02:46:16 UTC 2016
On Wed, Dec 7, 2016 at 12:37 AM, David Disseldorp <ddiss at suse.de> wrote:
> And again with the patch-set attached - I'm on fire today :-/
> On Tue, 6 Dec 2016 14:34:44 +0100, David Disseldorp wrote:
> > On Tue, 6 Dec 2016 18:24:30 +1100, Amitay Isaacs wrote:
> > > Sorry for not responding earlier. NACK on this patch.
> > >
> > > This is incomplete patch. Anything that is not required for core
> > > does not belong in ctdb/tools.
> > >
> > > - This code and doc belongs in ctdb/utils/etcd.
> > > - This should be installed only with --enable-etcd (or such option).
> > I don't think these concerns warrant a revert. The attached patch-set
> > moves the code (not the doc) to ctdb/utils/etcd, and adds a new
> > --enable-etcd-reclock configure switch. Would this be sufficient?
> > I'd prefer to keep the man page under doc/. We could change the
> > makefiles to only generate/install if --enable-etcd-reclock is flagged.
> > Cheers, David
I agree with manpages staying in doc.
In patch 2, we need to add a check for etcd python module.
We also need to install the man page conditionally.
More information about the samba-technical