ctdb reclock API for etcd/librados

David Disseldorp ddiss at suse.de
Tue Dec 6 13:37:48 UTC 2016


And again with the patch-set attached - I'm on fire today :-/

On Tue, 6 Dec 2016 14:34:44 +0100, David Disseldorp wrote:

> On Tue, 6 Dec 2016 18:24:30 +1100, Amitay Isaacs wrote:
> 
> > Sorry for not responding earlier.  NACK on this patch.
> > 
> > This is incomplete patch.  Anything that is not required for core operation
> > does not belong in ctdb/tools.
> > 
> > - This code and doc belongs in ctdb/utils/etcd.
> > - This should be installed only with --enable-etcd (or such option).  
> 
> I don't think these concerns warrant a revert. The attached patch-set
> moves the code (not the doc) to ctdb/utils/etcd, and adds a new
> --enable-etcd-reclock configure switch. Would this be sufficient?
> 
> I'd prefer to keep the man page under doc/. We could change the
> makefiles to only generate/install if --enable-etcd-reclock is flagged.
> 
> Cheers, David

-------------- next part --------------
A non-text attachment was scrubbed...
Name: etcd_reclock_conf_switch_and_mv_utils.patchset
Type: text/x-patch
Size: 3764 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20161206/d6498e51/etcd_reclock_conf_switch_and_mv_utils.bin>


More information about the samba-technical mailing list