some valgrind patches

[Stefan Metzmacher]

Am 22.04.2016 um 11:06 schrieb Volker Lendecke:
> On Fri, Apr 22, 2016 at 07:34:31AM +0100, Noel Power wrote:
>> On 21/04/16 15:46, Volker Lendecke wrote:
>>> On Thu, Apr 21, 2016 at 01:57:53PM +0100, Noel Power wrote:
>>>> Hi,
>>>> Here are some patches to fix some issues discovered by running
>>>> smbtorture itself under valgrind
>>> Looks very good! Does that survive an autobuild?
>> not sure what autobuild actually is... but make test passes (with the
>> patches)
> 
> The fix for
> 
> librpc:rpc: fix 'Invalid read of size 8' valgrind error
> 
> is in the wrong place I think. Shouldn't this be fixed in
> torture_dsgetinfo_tcase_teardown?
>
> If we want to protect dcerpc_binding_handle_call from a NULL handle,
> we should do it in dcerpc_binding_handle_call_send to also protect the
> async send/recv. Also, dcerpc_binding_handle_raw_call would need the
> same protection.

I don't think we want protection there.
I haven't looked at the patch, but the caller
(torture_dsgetinfo_tcase_teardown ?)
should be fixed.

metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160422/5abbb05c/signature.sig>