some valgrind patches

Noel Power nopower at
Fri Apr 22 10:24:02 UTC 2016

On 22/04/16 10:31, Stefan Metzmacher wrote:
> Am 22.04.2016 um 11:06 schrieb Volker Lendecke:
>> On Fri, Apr 22, 2016 at 07:34:31AM +0100, Noel Power wrote:
>>> On 21/04/16 15:46, Volker Lendecke wrote:
>>>> On Thu, Apr 21, 2016 at 01:57:53PM +0100, Noel Power wrote:
>>>>> Hi,
>>>>> Here are some patches to fix some issues discovered by running
>>>>> smbtorture itself under valgrind
>>>> Looks very good! Does that survive an autobuild?
>>> not sure what autobuild actually is... but make test passes (with the
>>> patches)
>> The fix for
>> librpc:rpc: fix 'Invalid read of size 8' valgrind error
>> is in the wrong place I think. Shouldn't this be fixed in
>> torture_dsgetinfo_tcase_teardown?
>> If we want to protect dcerpc_binding_handle_call from a NULL handle,
>> we should do it in dcerpc_binding_handle_call_send to also protect the
>> async send/recv. Also, dcerpc_binding_handle_raw_call would need the
>> same protection.
> I don't think we want protection there.
> I haven't looked at the patch, but the caller
> (torture_dsgetinfo_tcase_teardown ?)
> should be fixed.
sure I can look at fixing it there, might wait though till the rest are
reviewed before resending the (rather large) patch set


More information about the samba-technical mailing list