some valgrind patches

Volker Lendecke Volker.Lendecke at SerNet.DE
Fri Apr 22 09:06:29 UTC 2016

On Fri, Apr 22, 2016 at 07:34:31AM +0100, Noel Power wrote:
> On 21/04/16 15:46, Volker Lendecke wrote:
> > On Thu, Apr 21, 2016 at 01:57:53PM +0100, Noel Power wrote:
> >> Hi,
> >> Here are some patches to fix some issues discovered by running
> >> smbtorture itself under valgrind
> > Looks very good! Does that survive an autobuild?
> not sure what autobuild actually is... but make test passes (with the
> patches)

The fix for

librpc:rpc: fix 'Invalid read of size 8' valgrind error

is in the wrong place I think. Shouldn't this be fixed in

If we want to protect dcerpc_binding_handle_call from a NULL handle,
we should do it in dcerpc_binding_handle_call_send to also protect the
async send/recv. Also, dcerpc_binding_handle_raw_call would need the
same protection.

With best regards,

Volker Lendecke

SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen, mailto:kontakt at

More information about the samba-technical mailing list