Some coverity fixes

Michael Adam obnox at samba.org
Thu Sep 10 08:08:06 UTC 2015


On 2015-09-10 at 09:49 +0200, Andreas Schneider wrote:
> On Thursday, September 10, 2015 10:48:29 AM Anoop C S wrote:
> > On Wed, 2015-09-09 at 18:12 +0200, Michael Adam wrote:
> > > On 2015-09-09 at 17:40 +0200, G√ľnther Deschner wrote:
> > > > -----BEGIN PGP SIGNED MESSAGE-----
> > > > Hash: SHA1
> > > > 
> > > > Hi Anoop,
> > > > 
> > > > RB+ (as already reviewed off-list today).
> > > 
> > > The patches look good.
> > > 
> > > The patch to nss_wrapper needs to be done
> > > to the nss_wrapper repo. Usually we would pick up
> > > from nss_wrapper (and friends) by moving to a new
> > > 'upstream' version (unless it is very urgent).
> > > 
> > > Nsswrapper repo is: git://git.samba.org/nss_wrapper.git
> > > 
> > > I am going to push the other ones for a start.
> > 
> > Thanks. I have attached the patch to reflect the change w.r.t
> > nss_wrapper git repo.
> 
> Can you please be more precise which is wrong with this code? We have 
> nss_wrapper in scan.covertiy.com and I do not the the issue there.

"node == NULL" is already covered a few lines above,
so the removed hunk is obviously dead code.

> Also we restructured this code in the function, see
> 
> https://github.com/marmolak/nss_wrapper/commit/288d64536c845aeaa0df61e4ce98e8358eb8c46f#diff-6710f2fe0a72488fdf962b4539266cbfR4338
> 
> This is work in progress.

Work in progress always has to adapt to what is happening upstream. ;-)
Should not be too difficult to resolve the conflicts once the WIP
is ready.

Just my $0.02...

Cheers - Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150910/11d269cf/attachment.sig>


More information about the samba-technical mailing list