[PR PATCH] [Updated] build:wafsamba: dead code removal in gettext detection

[Uri Simchoni]

On 10/25/2015 01:07 AM, github at samba.org wrote:
> There is an updated pull request by ita1024 against master on the Samba Samba Github repository
>
> https://github.com/ita1024/samba cflags_noeffect
> https://github.com/samba-team/samba/pull/27
>
> build:wafsamba: dead code removal in gettext detection
> The values conf.env.CFLAGS and conf.env.LDFLAGS have no effect in waf 1.5
> Additionally, values must be appended using:
> conf.env.append_value('CCFLAGS', value)
>
Wouldn't conf.ADD_EXTRA_INCLUDES be more suitable? No a waf expert but 
it always seems more reasonable to me to separate  compiler translation 
flags from pre-processor flags.
If that's not suitable for some reason, I see we also have ADD_CFLAGS...

Thanks,
Uri.