[PR PATCH] [Updated] build:wafsamba: dead code removal in gettext detection

github at samba.org github at samba.org
Sat Oct 24 22:07:18 UTC 2015


There is an updated pull request by ita1024 against master on the Samba Samba Github repository

https://github.com/ita1024/samba cflags_noeffect
https://github.com/samba-team/samba/pull/27

build:wafsamba: dead code removal in gettext detection
The values conf.env.CFLAGS and conf.env.LDFLAGS have no effect in waf 1.5
Additionally, values must be appended using:
conf.env.append_value('CCFLAGS', value)
Keep in mind that conf.env.CCFLAGS returns an empty list when not undefined,
which means that extending that list will have no effect at all.

Signed-off-by: Thomas Nagy <tnagy at waf.io>
Reviewed-by: <your name here>
Reviewed-by: <your name here>

A patch file from https://github.com/samba-team/samba/pull/27.patch is attached
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: github-pr-cflags_noeffect-27.patch
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20151024/2b06f211/github-pr-cflags_noeffect-27.patch>


More information about the samba-technical mailing list