[PATCH] Fix compiler warning
Anoop C S
anoopcs at redhat.com
Thu Oct 22 04:51:41 UTC 2015
On Wed, 2015-10-21 at 13:24 -0700, Jeremy Allison wrote:
> On Wed, Oct 21, 2015 at 09:21:09AM +0530, Anoop C S wrote:
> >
> > Thank you for pointing out the missing goto. Please see the
> > attached
> > patch which reflects the changes mentioned above.
>
> You have some whitespace issues here.
>
> E.g.:
>
> > + * gqr.status returns 1 if quotas exist, 2 if there is
> > + * no quota set, and 3 if no permission to get the quota.
> > + * If 3, return something sensible.
>
> The "* If 3, return something sensible." line should match
> up column-wise with the two above.
>
> Also:
>
> > + ret = False;
> > + goto out;
>
> Should be "ret = false" - we're trying to eventually
> move away from our old hand-created True/False macros.
>
> Other than that looks good - can you fix and resubmit ?
>
Sure. I have made changes accordingly in the attached patch. Please let
me know if any more changes are required.
--Anoop C S.
> Jeremy.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-smbd-quotas-Remove-invalid-quota-status-switch-case.patch
Type: text/x-patch
Size: 1938 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20151022/d8b02c25/0001-smbd-quotas-Remove-invalid-quota-status-switch-case.bin>
More information about the samba-technical
mailing list