[PATCH] Fix compiler warning

Michael Adam obnox at samba.org
Fri Oct 23 19:36:51 UTC 2015


LGTM - I think all of Jeremy's comments have been addressed.

reviewed by me.

Michael

On 2015-10-22 at 10:21 +0530, Anoop C S wrote:
> On Wed, 2015-10-21 at 13:24 -0700, Jeremy Allison wrote:
> > On Wed, Oct 21, 2015 at 09:21:09AM +0530, Anoop C S wrote:
> > > 
> > > Thank you for pointing out the missing goto. Please see the
> > > attached
> > > patch which reflects the changes mentioned above.
> > 
> > You have some whitespace issues here.
> > 
> > E.g.:
> > 
> > > +      * gqr.status returns 1 if quotas exist, 2 if there is
> > > +      * no quota set, and 3 if no permission to get the quota.
> > > +         * If 3, return something sensible.
> > 
> > The "* If 3, return something sensible." line should match
> > up column-wise with the two above.
> > 
> > Also:
> > 
> > > +                ret = False;
> > > +                goto out;
> > 
> > Should be "ret = false" - we're trying to eventually
> > move away from our old hand-created True/False macros.
> > 
> > Other than that looks good - can you fix and resubmit ?
> > 
> 
> Sure. I have made changes accordingly in the attached patch. Please let
> me know if any more changes are required.
> 
> --Anoop C S.
> 
> > Jeremy.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20151023/cb30e6bb/signature.sig>


More information about the samba-technical mailing list