[PATCH] Fix compiler warning

Jeremy Allison jra at samba.org
Wed Oct 21 20:24:35 UTC 2015


On Wed, Oct 21, 2015 at 09:21:09AM +0530, Anoop C S wrote:
> 
> Thank you for pointing out the missing goto. Please see the attached
> patch which reflects the changes mentioned above.

You have some whitespace issues here.

E.g.:

> +      * gqr.status returns 1 if quotas exist, 2 if there is
> +      * no quota set, and 3 if no permission to get the quota.
> +         * If 3, return something sensible.

The "* If 3, return something sensible." line should match
up column-wise with the two above.

Also:

> +                ret = False;
> +                goto out;

Should be "ret = false" - we're trying to eventually
move away from our old hand-created True/False macros.

Other than that looks good - can you fix and resubmit ?

Jeremy.



More information about the samba-technical mailing list