[PATCH] Add Unix attributes to a user or group in AD

[Rowland Penny]

On 09/11/15 09:50, Rowland Penny wrote:
> On 09/11/15 09:40, Michael Adam wrote:
>> On 2015-11-09 at 09:11 +0000, Rowland Penny wrote:
>>> On 27/10/15 16:01, Rowland Penny wrote:
>>>> Hi, the attached patches allow for the adding of Unix attributes to an
>>>> already created user or group, they work much in the same way as
>>>> 'samba-tool user create' does except it requires a user or group that
>>>> already exists.
>>>>
>>>> The first patch allows to get an AD objects DN from its samaccountname
>>>> The second allows samba-tool to update a user
>>>> The third allows samba-tool to update a group
>>>>
>>>> I think this is going to be required now that ADUC on win10 doesn't 
>>>> come
>>>> with the UNIX Attributes tab.
>>>>
>>>> Rowland
>>> Any chance of a reply to this??? Even if it is 'Go Away' :-)
>> Oh, missed it before.
>>
>> Thanks for the patches!
>> That is indeed a must-have feature, imho!
>>
>> The patches look very good to me in general, just one question:
>> Why not allow for selectively setting some of the attributes
>> for a user but instead require specifying them all?
>
> Because this is the way it works if you add them when you create a 
> user, it is also the way ADUC works.
>
>>
>> And we need manpage updates.
>
> Well this could have been said when 'samba-tool user create' was 
> altered to add the Unix attributes, but I will look into it after the 
> patches are added.


Has anybody ever really updated 'man samba-tool' ????, anyway I have 
attached an update to the manpage for my patches.

Rowland

>
>> And ideally tests.
>
> Ah, never written tests, any pointers ??
>
> Rowland
>
>>
>> Cheers - Michael
>

-------------- next part --------------
>From d91468f9e429e72e13825d5730789cc022184f9c Mon Sep 17 00:00:00 2001
From: Rowland Penny <repenny241155 at gmail.com>
Date: Mon, 9 Nov 2015 10:43:28 +0000
Subject: [PATCH 2/2] samba-tool manpage: Add user & group 'nisadd' lines
 Signed-off-by: Rowland Penny <repenny241155 at gmail.com>

---
 docs-xml/manpages/samba-tool.8.xml |   12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/docs-xml/manpages/samba-tool.8.xml b/docs-xml/manpages/samba-tool.8.xml
index a575a20..03f8cbd 100644
--- a/docs-xml/manpages/samba-tool.8.xml
+++ b/docs-xml/manpages/samba-tool.8.xml
@@ -445,6 +445,12 @@
 </refsect3>
 
 <refsect3>
+	<title>group nisadd</title>
+	<para>Add RFC2307 attributes to a group, similar to using the ADUC 
+        UNIX Attributes tab.</para>
+</refsect3>
+
+<refsect3>
 	<title>group removemembers <replaceable>groupname</replaceable> <replaceable>members</replaceable> [options]</title>
 	<para>Remove members from the specified AD group.</para>
 </refsect3>
@@ -572,6 +578,12 @@
 </refsect3>
 
 <refsect3>
+	<title>user nisadd</title>
+	<para>Add RFC2307 attributes to a user, similar to using the ADUC 
+        UNIX Attributes tab.</para>
+</refsect3>
+
+<refsect3>
 	<title>user password [options]</title>
 	<para>Change password for an user account (the one provided in
 	authentication).</para>
-- 
1.7.10.4