[PATCH] Add Unix attributes to a user or group in AD

[Rowland Penny]

On 09/11/15 09:40, Michael Adam wrote:
> On 2015-11-09 at 09:11 +0000, Rowland Penny wrote:
>> On 27/10/15 16:01, Rowland Penny wrote:
>>> Hi, the attached patches allow for the adding of Unix attributes to an
>>> already created user or group, they work much in the same way as
>>> 'samba-tool user create' does except it requires a user or group that
>>> already exists.
>>>
>>> The first patch allows to get an AD objects DN from its samaccountname
>>> The second allows samba-tool to update a user
>>> The third allows samba-tool to update a group
>>>
>>> I think this is going to be required now that ADUC on win10 doesn't come
>>> with the UNIX Attributes tab.
>>>
>>> Rowland
>> Any chance of a reply to this??? Even if it is 'Go Away' :-)
> Oh, missed it before.
>
> Thanks for the patches!
> That is indeed a must-have feature, imho!
>
> The patches look very good to me in general, just one question:
> Why not allow for selectively setting some of the attributes
> for a user but instead require specifying them all?

Because this is the way it works if you add them when you create a user, 
it is also the way ADUC works.

>
> And we need manpage updates.

Well this could have been said when 'samba-tool user create' was altered 
to add the Unix attributes, but I will look into it after the patches 
are added.

> And ideally tests.

Ah, never written tests, any pointers ??

Rowland

>
> Cheers - Michael