[PATCH] Add Unix attributes to a user or group in AD

[Michael Adam]

On 2015-11-09 at 09:50 +0000, Rowland Penny wrote:
> On 09/11/15 09:40, Michael Adam wrote:
> >On 2015-11-09 at 09:11 +0000, Rowland Penny wrote:
> >>On 27/10/15 16:01, Rowland Penny wrote:
> >>>Hi, the attached patches allow for the adding of Unix attributes to an
> >>>already created user or group, they work much in the same way as
> >>>'samba-tool user create' does except it requires a user or group that
> >>>already exists.
> >>>
> >>>The first patch allows to get an AD objects DN from its samaccountname
> >>>The second allows samba-tool to update a user
> >>>The third allows samba-tool to update a group
> >>>
> >>>I think this is going to be required now that ADUC on win10 doesn't come
> >>>with the UNIX Attributes tab.
> >>>
> >>>Rowland
> >>Any chance of a reply to this??? Even if it is 'Go Away' :-)
> >Oh, missed it before.
> >
> >Thanks for the patches!
> >That is indeed a must-have feature, imho!
> >
> >The patches look very good to me in general, just one question:
> >Why not allow for selectively setting some of the attributes
> >for a user but instead require specifying them all?
> 
> Because this is the way it works if you add them when you create a user, it
> is also the way ADUC works.

Ok, understood when newly adding these attributes.
But this command could also be used to later
change individual of these attributes, right?

But then, the commands should not be called '.. nisadd'
but '... setnis' instead, or so.

But maybe for for the purposes above, we might want
individual command to set the individual attrs?
Just brainstorming aloud...

> >And we need manpage updates.
> 
> Well this could have been said when 'samba-tool user create' was altered to
> add the Unix attributes, but I will look into it after the patches are
> added.

Anyways, you add a new subcommand. Hence a patch to add a
description of this new command to the samba-tool manpage
would be appreciated.

> >And ideally tests.
> 
> Ah, never written tests, any pointers ??

e.g.  python/samba/tests/samba_tool/user.py

One cosmetic note:

in the second patch, a newline is missing after the first
line of the commit message, so the signed-off-by is concatenated
with the subject line.


Thanks for your work!


Cheers - Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20151109/ba21097d/signature.sig>