[PATCH v3 0/5] Waf: Semi-automatic generation of results for cross-answers files

Alexander Bokovoy ab at samba.org
Mon May 18 08:02:01 MDT 2015

On Mon, May 18, 2015 at 10:00:03AM +0300, Uri Simchoni wrote:
> OK here goes v4 of this patchset - only diff from v3 is for autobuild
> to output the diff in resulting configurations in case they  differ.
Thanks for the patches.

Patch v4 1/5:
 - please split it into two separate patches: one handling the missing
   f.close() and retstring cleanup, the other for actually adding
   --cross-answers and --crose-execute options.

Patch v4 2/5: ACK

Patch v4 3/5: ACK

Patch v4 4/5:
 - please add --verbos to rsync options in xfer_files and add a comment
   to mention that remote files will be removed on target. Perhaps split
   the cmd string into some parts to allow people a bit easier to
   manipulate it? For those who wouldn't be careful enough, removal of
   files on the target might be a surprise.
 - also would be good to add a separate directory than just a homedir as
   a target.

Patch v4 5/5:
 - please split it into two (or three) separate patches: one for adding
   'samba-xc' task in autobuild.py, and other adding the scripts.

/ Alexander Bokovoy

More information about the samba-technical mailing list