[PATCH v3 0/5] Waf: Semi-automatic generation of results for cross-answers files

Uri Simchoni urisimchoni at gmail.com
Mon May 18 01:00:03 MDT 2015

OK here goes v4 of this patchset - only diff from v3 is for autobuild
to output the diff in resulting configurations in case they  differ.


On Mon, May 18, 2015 at 8:15 AM, Andrew Bartlett <abartlet at samba.org> wrote:
> On Wed, 2015-05-13 at 00:45 +0300, Uri Simchoni wrote:
>> Ping...
>> The core of the patch is the same as v2, with modified example and added
>> autobuild run.
> Thanks.  Sorry to ask one more thing, but rather than using a hash check
> for differences, could you use difflib to create a unified diff?
> https://docs.python.org/2/library/difflib.html
> The reason I ask is that when a developer breaks this (because that is
> why we are testing), we need to give them the best clues possible as to
> what went wrong, and a diff on stdout of the normalised files would be
> very helpful to them.  (Autobuild will throw away the build tree by the
> time the developer gets the failure mail, so they won't be able to look
> into it manually).
> Thanks,
> Andrew Bartlett
> --
> Andrew Bartlett                       http://samba.org/~abartlet/
> Authentication Developer, Samba Team  http://samba.org
> Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba
-------------- next part --------------
A non-text attachment was scrubbed...
Name: waf_cc_v4.patch
Type: application/octet-stream
Size: 17632 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150518/ed252518/attachment.obj>

More information about the samba-technical mailing list