[PATCH v3 0/5] Waf: Semi-automatic generation of results for cross-answers files

Andrew Bartlett abartlet at samba.org
Sun May 17 23:15:26 MDT 2015


On Wed, 2015-05-13 at 00:45 +0300, Uri Simchoni wrote:
> Ping...
> The core of the patch is the same as v2, with modified example and added
> autobuild run.

Thanks.  Sorry to ask one more thing, but rather than using a hash check
for differences, could you use difflib to create a unified diff?

https://docs.python.org/2/library/difflib.html

The reason I ask is that when a developer breaks this (because that is
why we are testing), we need to give them the best clues possible as to
what went wrong, and a diff on stdout of the normalised files would be
very helpful to them.  (Autobuild will throw away the build tree by the
time the developer gets the failure mail, so they won't be able to look
into it manually).

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba




More information about the samba-technical mailing list