[PATCH v3 0/5] Waf: Semi-automatic generation of results for cross-answers files

Uri Simchoni urisimchoni at gmail.com
Tue May 19 03:17:36 MDT 2015

Thanks for reviewing. Hre's version 5 with the following:

v5 1/10, 2/10/, 3/10 --> same as v4 1/5 but split to differentiate bug
fixes from the added feature
v5 4/10 --> same as v4 2/5
v5 5/10 --> a new bugfix to cross-execute (found thanks to Alexander's
insistence on providing something really useful and not some sample to
build upon)
v5 6/10 --> same as v4 3/5
v5 7/10 --> new version of v4 4/5 sample cross-execute program, making
it more configurable,
                 better documentation of usage and assumptions
v5 8/10, 9/10, 10/10 --> same as v4 5/5, but split to ease review


On Mon, May 18, 2015 at 5:02 PM, Alexander Bokovoy <ab at samba.org> wrote:
> On Mon, May 18, 2015 at 10:00:03AM +0300, Uri Simchoni wrote:
>> OK here goes v4 of this patchset - only diff from v3 is for autobuild
>> to output the diff in resulting configurations in case they  differ.
> Thanks for the patches.
> Patch v4 1/5:
>  - please split it into two separate patches: one handling the missing
>    f.close() and retstring cleanup, the other for actually adding
>    --cross-answers and --crose-execute options.
> Patch v4 2/5: ACK
> Patch v4 3/5: ACK
> Patch v4 4/5:
>  - please add --verbos to rsync options in xfer_files and add a comment
>    to mention that remote files will be removed on target. Perhaps split
>    the cmd string into some parts to allow people a bit easier to
>    manipulate it? For those who wouldn't be careful enough, removal of
>    files on the target might be a surprise.
>  - also would be good to add a separate directory than just a homedir as
>    a target.
> Patch v4 5/5:
>  - please split it into two (or three) separate patches: one for adding
>    'samba-xc' task in autobuild.py, and other adding the scripts.
> --
> / Alexander Bokovoy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: waf_cc_v5.patch
Type: application/octet-stream
Size: 25512 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150519/dba82f92/attachment.obj>

More information about the samba-technical mailing list