PATCH multi-channel & fd passing
jra at samba.org
Wed Mar 18 14:50:02 MDT 2015
On Wed, Mar 18, 2015 at 08:22:07PM +0100, Michael Adam wrote:
> Hi Noel,
> On 2015-03-18 at 18:35 +0000, Noel Power wrote:
> > I failed while trying Michael's multi-channel demo
> > (http://blog.obnox.de/demo-of-smb3-multi-channel-with-samba/) with
> > master,
> I hope you tried multi-channel not with plain master but with my
> (or metze's multi-channel) branch... ;-)
> > following patch(s) seem to make things better (note: second
> > patch is not necessary, just a minor cosmetic tweak)
> Thanks, gonna look/test next.
> And thanks for thesting the WIP code!
NAK on the second cosmetic patch. It removes an early
return just to remove an anonymous block.
Having early returns trumps anonymous blocks (IMHO).
First patch LGTM !
More information about the samba-technical