[PATCH] smbd: Fix bug 10839

[Volker Lendecke]

On Thu, Feb 26, 2015 at 12:59:51PM +0100, David Disseldorp wrote:
> Hi Volker,
> 
> On Wed, 25 Feb 2015 22:03:31 +0100, Volker Lendecke wrote:
> 
> > This is a patch I'd like to propse for master. The bug is
> > not strictly a Samba bug, Windows->Windows must have the
> > same problem, but it's unlikely to get fixed in Windows. As
> > it affects a real user I've talked to recently, I would like
> > to get this in.
> 
> I think the ignore logic would be a little cleaner if self contained in
> smbd_smb2_request_verify_creditcharge() - [g/s]etinfo/notify callers
> could then just provide a xconn->smb2.credits.ignore_broken_multicredit
> argument. Also, the new parameter should be documented in the smb.conf

Hmm. Does this mean we have to pass a boolean flag down? I'd
rather go and make a separate routine out of this then.

> Finally, the last hunk duplicates the status check...
> +       status = smbd_smb2_request_verify_creditcharge(req, credit_charge);
> +       if (!NT_STATUS_IS_OK(status)) {
> +               return smbd_smb2_request_error(req, status);
> +       }
> +

Oh, ok. Thanks :-)

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de