[PATCH] smbd: Fix bug 10839

David Disseldorp ddiss at suse.de
Thu Feb 26 04:59:51 MST 2015

Hi Volker,

On Wed, 25 Feb 2015 22:03:31 +0100, Volker Lendecke wrote:

> This is a patch I'd like to propse for master. The bug is
> not strictly a Samba bug, Windows->Windows must have the
> same problem, but it's unlikely to get fixed in Windows. As
> it affects a real user I've talked to recently, I would like
> to get this in.

I think the ignore logic would be a little cleaner if self contained in
smbd_smb2_request_verify_creditcharge() - [g/s]etinfo/notify callers
could then just provide a xconn->smb2.credits.ignore_broken_multicredit
argument. Also, the new parameter should be documented in the smb.conf
man page.

Finally, the last hunk duplicates the status check...
+       status = smbd_smb2_request_verify_creditcharge(req, credit_charge);
+       if (!NT_STATUS_IS_OK(status)) {
+               return smbd_smb2_request_error(req, status);
+       }
        if (!NT_STATUS_IS_OK(status)) {
                return smbd_smb2_request_error(req, status);

Cheers, David

More information about the samba-technical mailing list