[PATCH] smbd: Fix bug 10839

David Disseldorp ddiss at suse.de
Thu Feb 26 05:27:09 MST 2015


On Thu, 26 Feb 2015 13:16:28 +0100, Volker Lendecke wrote:

> > I think the ignore logic would be a little cleaner if self contained in
> > smbd_smb2_request_verify_creditcharge() - [g/s]etinfo/notify callers
> > could then just provide a xconn->smb2.credits.ignore_broken_multicredit
> > argument. Also, the new parameter should be documented in the smb.conf  
> 
> Hmm. Does this mean we have to pass a boolean flag down?

I'd prefer that to overwriting the data_length with the magic "ignore"
value.

Cheers, David


More information about the samba-technical mailing list