[PATCH] Allow Huawei Unified Storage System S5500 V3 to join the AD DC

Simo simo at samba.org
Tue Aug 4 18:12:36 UTC 2015


On Tue, 2015-08-04 at 08:07 +0200, Stefan Metzmacher wrote:
> Hi Andrew,
> 
> > +	if (lpcfg_parm_bool(gensec_security->settings->lp_ctx,
> > +			    NULL, "gensec_krb5", 
> > "send_authenticator_checksum", true)) {
> > +		in_data.length = 0;
> > +		in_data_p = &in_data;
> > +	}
> > +
> 
> Please use a helper 'bool' variable instead of a function call in the 
> if
> statement.
> 
> Can we also use
> 
> krb5_data in_data = { .length = 0 }; to fully and always initialize 
> in_data.
> 
> Otherwise Reviewed-by: me

FYI
I opened this pull request for the MIT code base: 
https://github.com/krb5/krb5/pull/306

Simo.



More information about the samba-technical mailing list