[PATCH] Allow Huawei Unified Storage System S5500 V3 to join the AD DC

[Stefan Metzmacher]

Hi Andrew,

> +	if (lpcfg_parm_bool(gensec_security->settings->lp_ctx,
> +			    NULL, "gensec_krb5", "send_authenticator_checksum", true)) {
> +		in_data.length = 0;
> +		in_data_p = &in_data;
> +	}
> +

Please use a helper 'bool' variable instead of a function call in the if
statement.

Can we also use

krb5_data in_data = { .length = 0 }; to fully and always initialize in_data.

Otherwise Reviewed-by: me

Thanks!
metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150804/bedb2458/signature.sig>