[PATCHES] cluster api testing patches

[Günther Deschner]

On 30/07/15 18:47, Jeremy Allison wrote:
> On Fri, Jul 24, 2015 at 03:04:40PM +0200, Guenther Deschner wrote:
>> Hi,
>>
>> attached are some more patches for testing the cluster management
>> interface, notably the marshalling of the PROPERTY_LIST buffers.
>>
>> Please review and push.
> 
> LGTM - pushing. One comment though. In new code you
> do a lot of stuff like:
> 
> struct clusapi_XXXXXXXXXXXXXXXXXXXXXXXX r;
> 
> r.xxx = XXX
> r.yyy = YYY
> ...
> 
> r is on the stack, so I'd like to get into
> the habit of doing.
> 
> struct clusapi_GetResourceNetworkName r = { 0 };
> 
> when declaring, instead of having to add a
> ZERO_STRUCT(r);
> 
> Argg... Doesn't work with gcc warnings,
> never mind :-).
> 
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53119
> 
> But think about adding ZERO_STRUCT(r)'s in
> future..
> 

Yep, I'll do or just set/initialize all members of 'r' manually (which I
did, AFAICT).

Thanks,
Guenther

-- 
Günther Deschner                    GPG-ID: 8EE11688
Red Hat                         gdeschner at redhat.com
Samba Team                              gd at samba.org