[PATCHES] more loadparm cleanup
ira at samba.org
Thu Apr 30 05:48:01 MDT 2015
I caught 1-2 more things... they are minor also.
03/22 Need to make sure the case matches in patch.
04/22 Do we want to note the previous use of these flags? (Do we need
+1 on Ralph's comment.. and I'd probably just squash all the directory
updates. But that's a taste issue.
On Thu, Apr 30, 2015 at 7:43 AM, Ralph Böhme <rb at sernet.de> wrote:
> Hi obnox
> On Wed, Apr 29, 2015 at 01:19:44AM +0200, Michael Adam wrote:
> > attached find code that cleans up our loadparm
> > by removing flags specific to swat which has
> > been removed.
> > Note: the change that removes the flags from
> > the xml documents under docs-xml/smbdotconf
> > has been split into several commits, one per
> > subdirectory, for better overview. If desired,
> > these can also be squashed.
> > Review/comments/push appreciated.
> in b886e93 you
> keep ... FLAG_META, which might become useful.
> And then in the subsequent commit you
> param: remove unused FLAG_META
> Any reason not to squash both and update the commit message?
> Other then that: LGTM.
> SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
> phone: +49-551-370000-0, fax: +49-551-370000-9
> AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
More information about the samba-technical