[PATCHES] more loadparm cleanup
obnox at samba.org
Thu Apr 30 11:42:19 MDT 2015
On 2015-04-30 at 07:48 -0400, Ira Cooper wrote:
> On Thu, Apr 30, 2015 at 7:43 AM, Ralph Böhme <rb at sernet.de> wrote:
> > On Wed, Apr 29, 2015 at 01:19:44AM +0200, Michael Adam wrote:
> > > attached find code that cleans up our loadparm
> > > by removing flags specific to swat which has
> > > been removed.
> > >
> > > Note: the change that removes the flags from
> > > the xml documents under docs-xml/smbdotconf
> > > has been split into several commits, one per
> > > subdirectory, for better overview. If desired,
> > > these can also be squashed.
> > >
> > > Review/comments/push appreciated.
> > in b886e93 you
> > keep ... FLAG_META, which might become useful.
> > And then in the subsequent commit you
> > param: remove unused FLAG_META
> > Any reason not to squash both and update the commit message?
Yes, we should do that.
I first omitted it and then changed my mind, forgot to squash.
> I caught 1-2 more things... they are minor also.
> 03/22 Need to make sure the case matches in patch.
Er, what do you mean here?
That's the P_SEP patch.
> 04/22 Do we want to note the previous use of these flags?
Do you mean in the commit message? Can do.
"These were previously used in SWAT, but are unused now."
> (Do we need tombstones?)
I am not certain. I am willing to listen to opinions/advice.
Maybe even simply keep them in the #defines but remove
them everywhere ese, so that they will not re-used?
> +1 on Ralph's comment..
+1 from me.
> and I'd probably just squash all the directory
> updates. But that's a taste issue.
As originally written: We can do this.
The form I sent was just meant for easier overview for each
When we have reached consensus for the above points, I will send
and updated patchset.
Thanks for your comments!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 198 bytes
Desc: not available
More information about the samba-technical