[PATCHES] more loadparm cleanup

Ralph Böhme rb at sernet.de
Thu Apr 30 05:43:27 MDT 2015


Hi obnox

On Wed, Apr 29, 2015 at 01:19:44AM +0200, Michael Adam wrote:
> attached find code that cleans up our loadparm
> by removing flags specific to swat which has
> been removed.
> 
> Note: the change that removes the flags from
> the xml documents under docs-xml/smbdotconf
> has been split into several commits, one per
> subdirectory, for better overview. If desired,
> these can also be squashed.
> 
> Review/comments/push appreciated.

in b886e93 you

   keep ... FLAG_META, which might become useful.

And then in the subsequent commit you

   param: remove unused FLAG_META

Any reason not to squash both and update the commit message?

Other then that: LGTM.

Cheerio!
-slow

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de,mailto:kontakt@sernet.de


More information about the samba-technical mailing list