[PATCH] Remove ctdb feature checks from configure
rb at sernet.de
Fri Oct 24 10:24:44 MDT 2014
On Fri, Oct 24, 2014 at 05:58:51PM +0200, Michael Adam wrote:
> On 2014-10-24 at 23:00 +1100, Amitay Isaacs wrote:
> > Whether we build CTDB standalone or as a top level build, we are always
> > going to build CTDB version that's bundled. We are NOT going to build smbd
> > file server version >= 4.2 with older ctdb versions. So there is no need
> > to check whether CTDB features are supported or not. If we want to use
> > some ctdb feature in smbd, then it better be there in ctdb.
> I looked over your patches, and I think they are mostly good.
> Is it certain that we are building against shipped ctdb
> if also a ctdb is installed with headers in /usr/include ?
> I guess/hope so, since the CTDB_INCLUDE should be checked
> before the standard include paths...
true. But fwiw, it will break if someone configured with CPPFLAGS to
include a path of a directory that does contain a copy of the
headers. Same for LDFLAGS and the library.
Excuse me for chiming in, but I wanted to take the occasion and point
to a general waf bug  I've been investigating the last days. ;)
Will post a full summary to the mailing list soon.
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
More information about the samba-technical