[PATCH] Remove ctdb feature checks from configure

[Michael Adam]

On 2014-10-24 at 18:24 +0200, Ralph Böhme wrote:
> On Fri, Oct 24, 2014 at 05:58:51PM +0200, Michael Adam wrote:
> > On 2014-10-24 at 23:00 +1100, Amitay Isaacs wrote:
> > >
> > > Whether we build CTDB standalone or as a top level build, we are always
> > > going to build CTDB version that's bundled.  We are NOT going to build smbd
> > > file server version >= 4.2 with older ctdb versions.  So there is no need
> > > to check whether CTDB features are supported or not.  If we want to use
> > > some ctdb feature in smbd, then it better be there in ctdb.
> > 
> > I looked over your patches, and I think they are mostly good.
> > 
> > Question:
> > Is it certain that we are building against shipped ctdb
> > if also a ctdb is installed with headers in /usr/include ?
> > 
> > I guess/hope so, since the CTDB_INCLUDE should be checked
> > before the standard include paths...
> 
> true. But fwiw, it will break if someone configured with CPPFLAGS to
> include a path of a directory that does contain a copy of the
> headers. Same for LDFLAGS and the library.
> 
> Excuse me for chiming in, but I wanted to take the occasion and point
> to a general waf bug [1] I've been investigating the last days. ;)

Well, no need to apologize!

> Will post a full summary to the mailing list soon.

Please do!

Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20141024/06e2e596/attachment.pgp>