[PATCH] Remove ctdb feature checks from configure

[Michael Adam]

On 2014-10-24 at 23:00 +1100, Amitay Isaacs wrote:
>
> Whether we build CTDB standalone or as a top level build, we are always
> going to build CTDB version that's bundled.  We are NOT going to build smbd
> file server version >= 4.2 with older ctdb versions.  So there is no need
> to check whether CTDB features are supported or not.  If we want to use
> some ctdb feature in smbd, then it better be there in ctdb.

I looked over your patches, and I think they are mostly good.

Question:
Is it certain that we are building against shipped ctdb
if also a ctdb is installed with headers in /usr/include ?

I guess/hope so, since the CTDB_INCLUDE should be checked
before the standard include paths...

Attached two additional patches by me to further
simplify and clean the checks.

> I agree with Michael that I have missed the autobuild and I should make
> sure that the samba-ctdb target builds correctly.

Attached is another patch to remove the separate ctdb build from
autobuild's samba-ctdb target.

If tests go well and we agree on the general direction
we can push the patchset, but I'd like to do a few more tests.
Currently running an autobuild with my patches on top of yours.

Cheers - Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-build-further-simplify-with-cluster-support-case-in-.patch
Type: text/x-diff
Size: 1680 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20141024/1afd65ad/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-build-adapt-comments-for-the-clustering-choice.patch
Type: text/x-diff
Size: 935 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20141024/1afd65ad/attachment-0001.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-autobuild-adapt-samba-ctdb-target-does-not-need-a-se.patch
Type: text/x-diff
Size: 2101 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20141024/1afd65ad/attachment-0002.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20141024/1afd65ad/attachment.pgp>