[PATCH] Remove ctdb feature checks from configure
amitay at gmail.com
Fri Oct 24 06:00:55 MDT 2014
On Fri, Oct 24, 2014 at 10:42 PM, Volker Lendecke <Volker.Lendecke at sernet.de
> On Fri, Oct 24, 2014 at 01:07:01PM +0200, Michael Adam wrote:
> > > As a simple example try including "server_id.h" somewhere. There's a
> > > reason why ctdb/client/ctdb_client.c has to duplicate the definition
> > > of struct server_id.
> > And what is the reason?
> The ctdb standalone build does not invoke pidl to autogenerate the C
> definition of struct server_id out of librpc/idl/server_id.idl. We need
> to modify the standalone ctdb build to also invoke pidl at least for
> this if we want to further integrate ctdb/ with toplevel infrastructure.
Whether we build CTDB standalone or as a top level build, we are always
going to build CTDB version that's bundled. We are NOT going to build smbd
file server version >= 4.2 with older ctdb versions. So there is no need
to check whether CTDB features are supported or not. If we want to use
some ctdb feature in smbd, then it better be there in ctdb.
I agree with Michael that I have missed the autobuild and I should make
sure that the samba-ctdb target builds correctly.
Also, I know there is duplication of certain structures (e.g. server_id) in
ctdb. Martin and I have worked hard to drop as much duplication from ctdb
as possible and re-use code available (including major work on lib/util).
It's not complete by any means. We are getting closer and some day we may
use PIDL generated code in ctdb. However, we are not there yet.
More information about the samba-technical