[PATCH] Add option --nis-domain and --gid to samba-tool group add

[Rowland Penny]

On 17/10/14 00:05, Michael Adam wrote:
> On 2014-10-12 at 19:02 +0200, Marc Muehlfeld wrote:
>> Hello,
>>
>> today we had a discussion on the samba mailing list about adding RFC2307
>> attributes to a group.
>>
>> Currently, if you don't use ADUC, you have to add the attributes
>> 'msSFU30NisDomain' and 'gidNumber' manually (e. g. via ldbedit). I
>> thought, it is helpful, if people could do this directly when creating
>> the group via samba-tool:
>>
>> # samba-tool group add demoGroup --nis-domain=samdom --gid-number=12345
>>
>> Find attached a patch for master. Please review and push, if OK. If it's
>> fine, can this be included in 4.2, too? Or is 4.2 already closed for new
>> features?
> Generally, this looks good.
> But is the code enough?
> One comment says:
> "Example3 adds a new RFC2307 enabled group for NIS domain samdom
> and GID 12345 (both options are required to enable this feature."
> But the code makes no special check for that.
> Maybe I'm just not the right one to review this
> and the check is done in deeper layers? :-)
>
> +Maybe an additional patch to adapt the manpage?
>
> Michael
Hi, can I also point out that if you do what Marc is proposing with 
ADUC, you also get the 'msSFU30Name' attribute.

Rowland