[PATCH] Add option --nis-domain and --gid to samba-tool group add

[Marc Muehlfeld]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello Michael,

thanks for having a look at my patch.



Am 17.10.2014 um 01:05 schrieb Michael Adam:
> Generally, this looks good. But is the code enough? One comment 
> says: "Example3 adds a new RFC2307 enabled group for NIS domain 
> samdom and GID 12345 (both options are required to enable this 
> feature." But the code makes no special check for that.

I added a check, to ensure, that both options are present or none.
Also I add now the 'msSFU30Name' attribute, like it's done by ADUC
(thanks to Rowland, for pointing me to that).

New patch attached. Please review and push, if OK.



> +Maybe an additional patch to adapt the manpage?

The current manpage of samba-tool in master, doesn't describe any
option of the different sub-commands. It just says

   group add groupname [options]
       Create a new AD group.

I think adding the different options for all sub-commands should be a
separate task. I can do this later. I created a feature request
(https://bugzilla.samba.org/show_bug.cgi?id=10884) and assigned it me.


Regards,
Marc
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJUQZ8AAAoJEFNERvHO3m51UuUH/0frgrtjY/gvjUXE/sJrqLNq
TrLKdIjRmJg583g4SDb7XjWQREaAJZclpdiTeOOfDmqA8atiwXDPYZCI2yackFYQ
g5nh4YQSz5foLneat9s3mlDEhnLgpa52JUEN30hcFov8Ww+fRNZSYzSEk23rjjkl
Qcq4HSe01CBP/UoUcL4niJCb7NKdReqIW6QAQc3dj8IgVWw4UajWjnBjm3/mQUXn
jKSual8SjSP4x5L2CLTJlaU6CxW+GiGl6x3RAiqOH3k9nMMfW0CGsY/+Pr7NMwP1
hNhLFggskGWt7IbccatG/neJJH6z2C/zprWrEp7iJL0kqJiaemmqDhNoK294aT0=
=qjiY
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-samba-tool-group-add-Add-option-nis-domain-and-gid.patch
Type: text/x-patch
Size: 4890 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20141018/d45e6da4/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-samba-tool-group-add-Add-option-nis-domain-and-gid.patch.sig
Type: application/pgp-signature
Size: 287 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20141018/d45e6da4/attachment.pgp>