[PATCH] Add option --nis-domain and --gid to samba-tool group add

Michael Adam obnox at samba.org
Thu Oct 16 17:05:17 MDT 2014

On 2014-10-12 at 19:02 +0200, Marc Muehlfeld wrote:
> Hello,
> today we had a discussion on the samba mailing list about adding RFC2307
> attributes to a group.
> Currently, if you don't use ADUC, you have to add the attributes
> 'msSFU30NisDomain' and 'gidNumber' manually (e. g. via ldbedit). I
> thought, it is helpful, if people could do this directly when creating
> the group via samba-tool:
> # samba-tool group add demoGroup --nis-domain=samdom --gid-number=12345
> Find attached a patch for master. Please review and push, if OK. If it's
> fine, can this be included in 4.2, too? Or is 4.2 already closed for new
> features?

Generally, this looks good.
But is the code enough?
One comment says:
"Example3 adds a new RFC2307 enabled group for NIS domain samdom
and GID 12345 (both options are required to enable this feature."
But the code makes no special check for that.
Maybe I'm just not the right one to review this
and the check is done in deeper layers? :-)

+Maybe an additional patch to adapt the manpage?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20141017/3244c822/attachment.pgp>

More information about the samba-technical mailing list