[PATCH] fix samba-tool dns serverinfo

[Günter Kukkukk]

Am 20.11.2014 um 11:46 schrieb Amitay Isaacs:
> Hi Günter,
> 
> On Tue, Nov 18, 2014 at 2:27 PM, Günter Kukkukk <linux at kukkukk.com> wrote:
> 
>> samba-tool dns serverinfo <some_server>
>>
>> In the initial (C-) implementation only IPv4 addresses were supported.
>> Add IPv6 (and mixed IPv4/IPv6) support and all further needed conversion
>> routines
>> to support w2k, dotnet, longhorn clients.
>>
>> Amitay, please review - and if OK - please push to autobuild.
>>
>> Got my local autobuild not working so far.
>>
>> Cheers, Günter
>>
> 
> Thanks for fixing IPv6 support in dnsserver RPC code.  Sorry for the late
> reply, a bit behind in catching up with the emails.
> 
> Few comments:
> 
> 1. Can you split the first patch and separate adding enum definition.
> That's strictly not related to the IPv6 address formatting.
> 
> 2. May be combine the dns.py changes since they are all related to IPv6
> address formatting.
> 
> 3. I would really prefer fill_dns_addr_array() function in dnsutils.c
> rather than dnsdata.c.  Then it can be a static function.
> 
> 4. Regarding this code snippet:
> 
> +        dns_addr_array->AddrArray =
> +            talloc_zero_array(mem_ctx, struct DNS_ADDR,
> +                      num_interfaces);
> +        if (dns_addr_array->AddrArray) {
> 
> I think we want to return NULL if talloc for dns_addr_array->AddrArray
> fails.  It's better to have no result rather than wrong result.
> 
> Amitay.
> 

Hi Amitay,

using your suggestions, i have re-worked all patches.

Please review and push to autobuild.

Thanks, Günter

-- 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-netcmd-dns.py-fix-enum-value.patch
Type: text/x-patch
Size: 931 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20141121/364fcde1/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-fix-the-display-of-IPv4-and-IPv6-address-strings-in-.patch
Type: text/x-patch
Size: 2187 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20141121/364fcde1/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Add-IPv6-support-to-samba-tool-dns-serverinfo-server.patch
Type: text/x-patch
Size: 11855 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20141121/364fcde1/attachment-0002.bin>