[PATCH] fix samba-tool dns serverinfo

Amitay Isaacs amitay at gmail.com
Sun Nov 23 20:59:49 MST 2014


On Sat, Nov 22, 2014 at 3:22 AM, Günter Kukkukk <linux at kukkukk.com> wrote:

> Am 20.11.2014 um 11:46 schrieb Amitay Isaacs:
> > Hi Günter,
> >
> > On Tue, Nov 18, 2014 at 2:27 PM, Günter Kukkukk <linux at kukkukk.com>
> wrote:
> >
> >> samba-tool dns serverinfo <some_server>
> >>
> >> In the initial (C-) implementation only IPv4 addresses were supported.
> >> Add IPv6 (and mixed IPv4/IPv6) support and all further needed conversion
> >> routines
> >> to support w2k, dotnet, longhorn clients.
> >>
> >> Amitay, please review - and if OK - please push to autobuild.
> >>
> >> Got my local autobuild not working so far.
> >>
> >> Cheers, Günter
> >>
> >
> > Thanks for fixing IPv6 support in dnsserver RPC code.  Sorry for the late
> > reply, a bit behind in catching up with the emails.
> >
> > Few comments:
> >
> > 1. Can you split the first patch and separate adding enum definition.
> > That's strictly not related to the IPv6 address formatting.
> >
> > 2. May be combine the dns.py changes since they are all related to IPv6
> > address formatting.
> >
> > 3. I would really prefer fill_dns_addr_array() function in dnsutils.c
> > rather than dnsdata.c.  Then it can be a static function.
> >
> > 4. Regarding this code snippet:
> >
> > +        dns_addr_array->AddrArray =
> > +            talloc_zero_array(mem_ctx, struct DNS_ADDR,
> > +                      num_interfaces);
> > +        if (dns_addr_array->AddrArray) {
> >
> > I think we want to return NULL if talloc for dns_addr_array->AddrArray
> > fails.  It's better to have no result rather than wrong result.
> >
> > Amitay.
> >
>
> Hi Amitay,
>
> using your suggestions, i have re-worked all patches.
>
> Please review and push to autobuild.
>
> Thanks, Günter
>
>
Hi Günter,

Patches look good now.  Two changes:

1. In the first patch the constant is DNS_ZONE_UPDATE_UNSECURE (from
dnsp.idl).  I have fixed the patch.

2. I have added an extra patch which adds early returns and removes extra
indent from your third patch.  You can squash the fixup patch in your patch.

Also, I have updated the commit messages and added Reviewed-by tags.

Amitay.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dns.patches
Type: application/octet-stream
Size: 17828 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20141124/17be4ec0/attachment.obj>


More information about the samba-technical mailing list