[PATCH] fix samba-tool dns serverinfo

Amitay Isaacs amitay at gmail.com
Thu Nov 20 03:46:38 MST 2014

Hi Günter,

On Tue, Nov 18, 2014 at 2:27 PM, Günter Kukkukk <linux at kukkukk.com> wrote:

> samba-tool dns serverinfo <some_server>
> In the initial (C-) implementation only IPv4 addresses were supported.
> Add IPv6 (and mixed IPv4/IPv6) support and all further needed conversion
> routines
> to support w2k, dotnet, longhorn clients.
> Amitay, please review - and if OK - please push to autobuild.
> Got my local autobuild not working so far.
> Cheers, Günter

Thanks for fixing IPv6 support in dnsserver RPC code.  Sorry for the late
reply, a bit behind in catching up with the emails.

Few comments:

1. Can you split the first patch and separate adding enum definition.
That's strictly not related to the IPv6 address formatting.

2. May be combine the dns.py changes since they are all related to IPv6
address formatting.

3. I would really prefer fill_dns_addr_array() function in dnsutils.c
rather than dnsdata.c.  Then it can be a static function.

4. Regarding this code snippet:

+        dns_addr_array->AddrArray =
+            talloc_zero_array(mem_ctx, struct DNS_ADDR,
+                      num_interfaces);
+        if (dns_addr_array->AddrArray) {

I think we want to return NULL if talloc for dns_addr_array->AddrArray
fails.  It's better to have no result rather than wrong result.


More information about the samba-technical mailing list