[PATCH] Fix bug #10587 - Opening directories on SLES's cifsd and Apple's smbx succeeds.

Jeremy Allison jra at samba.org
Thu May 8 20:47:34 MDT 2014

On Fri, May 09, 2014 at 12:19:11AM +0200, Stefan (metze) Metzmacher wrote:
> Do we really need this in smbclient?

Yes, otherwise smbclient fails in the same
way when recursively getting a directory
(doing archive/tar work).

> With caller I meant the libsmbclient glue code.

As above, both libsmbclient and smbclient need this.

It belongs in the cli_open() synchronous wrapper function,
that already has fallbacks for ugly situations
like this. It's obviously the correct place.

> Please avoid the ugly _internal_recv() function,
> just expose the attrs in the normal _recv and the sync function.

That means changing the ABI to the cli_ntcreate_recv().
I thought this was already exposed to external callers,
but checking I guess we're not guarenteeing this
interface externally.

OK, I'll fix it up to be the same as the smb2
version of the function that returns a struct
containing the full data returned from the
open in the _recv call.


More information about the samba-technical mailing list