[PATCH] Fix bug #10587 - Opening directories on SLES's cifsd and Apple's smbx succeeds.

Jeremy Allison jra at samba.org
Thu May 8 20:54:05 MDT 2014


On Thu, May 08, 2014 at 07:47:34PM -0700, Jeremy Allison wrote:
> On Fri, May 09, 2014 at 12:19:11AM +0200, Stefan (metze) Metzmacher wrote:
> 
> > Please avoid the ugly _internal_recv() function,
> > just expose the attrs in the normal _recv and the sync function.
> 
> That means changing the ABI to the cli_ntcreate_recv().
> I thought this was already exposed to external callers,
> but checking I guess we're not guarenteeing this
> interface externally.
> 
> OK, I'll fix it up to be the same as the smb2
> version of the function that returns a struct
> containing the full data returned from the
> open in the _recv call.

FYI - If I do it this way it's a *much*
bigger change, as it means changing
every caller of cli_ntcreate() and
also cli_nttrans_create() as well
(as we'll need the same return values
here).

Be careful what you wish for as I am
going to insist this gets back-ported
for 4.1.next and 4.0.next to fix this
damn bug.

Jeremy.


More information about the samba-technical mailing list