[PATCH] Fix bug #10587 - Opening directories on SLES's cifsd and Apple's smbx succeeds.

[Stefan (metze) Metzmacher]

Am 08.05.2014 23:04, schrieb Jeremy Allison:
> On Thu, May 08, 2014 at 01:57:43PM -0700, Jeremy Allison wrote:
>> On Thu, May 08, 2014 at 01:32:16PM -0700, Jeremy Allison wrote:
>>> On Thu, May 08, 2014 at 09:58:19PM +0200, Stefan (metze) Metzmacher wrote:
>>>> This is too much magic if the cli_foo() behaves differently as
>>>> cli_foo_send/recv().
>>>
>>> Yeah, I had qualms about it too, but it's the simplest
>>> fix I could come up with - not being able to change
>>> the gvfs or other libsmbclient callers.
>>>
>>> Or do you mean putting this change inside libsmbclient ?
>>>
>>> There is also precedence for this kind of change
>>> based on the fallback code inside cli_open() that
>>> tries ntcreateX first, and then fall back to
>>> openX if the server returns specific error codes:
>>
>> OK, how about the following. It puts all the
>> uglyness inside cli_open(), which is the
>> meta-call used by libsmbclient and smbclient.

Do we really need this in smbclient?
With caller I meant the libsmbclient glue code.

Please avoid the ugly _internal_recv() function,
just expose the attrs in the normal _recv and the sync function.
We should not break the tevent_req rules, so if you need an internal
function,
rename it completely and add a proper tevent_req based wrapper, or if
we only need a sync function only a sync wrapper.

metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 263 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140509/b7418b31/attachment.pgp>