[PATCH] Remove cached event context from irpc and imessaging
Stefan (metze) Metzmacher
metze at samba.org
Mon May 5 17:14:17 MDT 2014
Am 06.05.2014 01:05, schrieb Andrew Bartlett:
> On Mon, 2014-05-05 at 09:49 +0200, Stefan (metze) Metzmacher wrote:
>> Am 05.05.2014 07:16, schrieb Andrew Bartlett:
>>> The only part of this code with a stored event context is now the
>>> binding_handle created by irpc_binding_handle() in the client, and
>>> only if specified (otherwise a new nested event context is created).
>> As far as I can see the "only if specified" case is not done in the commit
>> and dcerpc_binding_handle_set_sync_ev() is still always called.
> It already did that internally (if you pass in NULL).
But we never pass NULL, so I think it's confusing in this commit message.
>> What about moving dcerpc_binding_handle_set_sync_ev() into the callers?
> A very reasonable suggestion for a follow-up patch. I'll see what I can
Thanks! I guess squashing this would make the patch simpler
as we don't have to add the 'tevent_context' argument and then remove it
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 263 bytes
Desc: OpenPGP digital signature
More information about the samba-technical