[PATCH] Remove cached event context from irpc and imessaging

Andrew Bartlett abartlet at samba.org
Mon May 5 19:13:17 MDT 2014

On Tue, 2014-05-06 at 01:14 +0200, Stefan (metze) Metzmacher wrote:
> Am 06.05.2014 01:05, schrieb Andrew Bartlett:
> > On Mon, 2014-05-05 at 09:49 +0200, Stefan (metze) Metzmacher wrote:
> >> Am 05.05.2014 07:16, schrieb Andrew Bartlett:
> >>> The only part of this code with a stored event context is now the
> >>> binding_handle created by irpc_binding_handle() in the client, and
> >>> only if specified (otherwise a new nested event context is created).
> >>
> >> As far as I can see the "only if specified" case is not done in the commit
> >> and dcerpc_binding_handle_set_sync_ev() is still always called.
> > 
> > It already did that internally (if you pass in NULL). 
> But we never pass NULL, so I think it's confusing in this commit message.
> >> What about moving dcerpc_binding_handle_set_sync_ev() into the callers?
> > 
> > A very reasonable suggestion for a follow-up patch.  I'll see what I can
> > do.
> Thanks! I guess squashing this would make the patch simpler
> as we don't have to add the 'tevent_context' argument and then remove it
> again.

I agree.  See attached, please review/push.  (I'm glad I prepared it in
two steps however, as it meant the compiler found all the calls I had to
add this after).


Andrew Bartlett

Andrew Bartlett
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-irpc-Remove-event-context-from-irpc-and-imessaging-s.patch
Type: text/x-patch
Size: 16525 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140506/1b75744f/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140506/1b75744f/attachment.pgp>

More information about the samba-technical mailing list