[PATCH] Remove cached event context from irpc and imessaging

Andrew Bartlett abartlet at samba.org
Mon May 5 17:05:13 MDT 2014

On Mon, 2014-05-05 at 09:49 +0200, Stefan (metze) Metzmacher wrote:
> Am 05.05.2014 07:16, schrieb Andrew Bartlett:
> > The only part of this code with a stored event context is now the
> > binding_handle created by irpc_binding_handle() in the client, and
> > only if specified (otherwise a new nested event context is created).
> As far as I can see the "only if specified" case is not done in the commit
> and dcerpc_binding_handle_set_sync_ev() is still always called.

It already did that internally (if you pass in NULL). 

> What about moving dcerpc_binding_handle_set_sync_ev() into the callers?

A very reasonable suggestion for a follow-up patch.  I'll see what I can

Andrew Bartlett

Andrew Bartlett
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140506/5539d27e/attachment.pgp>

More information about the samba-technical mailing list