[PATCH] Improve lib/param handling and remove another unused script

[Andrew Bartlett]

On Wed, 2014-01-29 at 21:46 +0100, Michael Adam wrote:
> On 2014-01-29 at 20:53 +0100, Michael Adam wrote:
> > On 2014-01-30 at 07:57 +1300, Andrew Bartlett wrote:
> > > > There are more occurrences of "-" in the code, e.g. in
> > > > lpcfg_next_parameter ..
> > > 
> > > Sure, and there is may have made sense, as lpcfg_next_parameter is like
> > > dump, an enumeration case.  Happily it is also unused, attached is the
> > > patch to just remove it, along with the also-unused lp_is_default. 
> > > 
> > > Please review/push.
> > 
> > Looks good - pushing to autobuild.
> 
> Sorry: The patches don't apply.
> One thing that caught my eye is that your
> patch uses lpcfg_equal_parameter, whereas
> current master uses equal_parameter.
> 
> Could you point me to more patches that need picking?

Sorry about that.  Try this set of patches, which includes some of the
other clean-up patches, including the ones you need for this case.

> I need an update which of your various patchsets are
> still missing review.

I'm tracking that in my param-after-reviews branch.  The big one is the
param-docs-metadata branch, which fixes up our docs to have enough
information for the code generator to do its job.

The other nicely separated set is the patch to use XML entities to have
correct paths in smb.conf.5.

Thanks!

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-param-pad-permissions-to-3-digits-and-update-docs-to.patch
Type: text/x-patch
Size: 2396 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140130/5b123f95/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-lib-param-Make-lpcfg_print_parameter-common.patch
Type: text/x-patch
Size: 5361 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140130/5b123f95/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-s3-param-Make-dump_a_parameter-use-lp_paramater-rath.patch
Type: text/x-patch
Size: 2276 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140130/5b123f95/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-s3-param-Use-lpcfg_dump_a_parameter-in-dump_a_parame.patch
Type: text/x-patch
Size: 1857 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140130/5b123f95/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-lib-param-Make-and-use-common-lpcfg_map_parameter.patch
Type: text/x-patch
Size: 6859 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140130/5b123f95/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-lib-param-Make-and-use-lpcfg_equal_parameter-in-comm.patch
Type: text/x-patch
Size: 5529 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140130/5b123f95/attachment-0005.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-param-remove-unused-bPreferredMaster-from-s3-loadpar.patch
Type: text/x-patch
Size: 872 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140130/5b123f95/attachment-0006.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0008-lib-param-Remove-unused-lpcfg_next_parameter-once-us.patch
Type: text/x-patch
Size: 2649 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140130/5b123f95/attachment-0007.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0009-param-Remove-unused-lp_next_parameter-once-used-by-S.patch
Type: text/x-patch
Size: 3045 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140130/5b123f95/attachment-0008.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0010-param-Remove-unused-lp_is_default-once-used-by-SWAT.patch
Type: text/x-patch
Size: 1930 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140130/5b123f95/attachment-0009.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0011-lib-param-Do-not-check-defaults_saved-in-is_default.patch
Type: text/x-patch
Size: 948 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140130/5b123f95/attachment-0010.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0012-param-Do-not-check-defaults_saved-in-is_default.patch
Type: text/x-patch
Size: 870 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140130/5b123f95/attachment-0011.bin>