[PATCH] Improve lib/param handling and remove another unused script

Michael Adam obnox at samba.org
Wed Jan 29 13:46:26 MST 2014


On 2014-01-29 at 20:53 +0100, Michael Adam wrote:
> On 2014-01-30 at 07:57 +1300, Andrew Bartlett wrote:
> > > There are more occurrences of "-" in the code, e.g. in
> > > lpcfg_next_parameter ..
> > 
> > Sure, and there is may have made sense, as lpcfg_next_parameter is like
> > dump, an enumeration case.  Happily it is also unused, attached is the
> > patch to just remove it, along with the also-unused lp_is_default. 
> > 
> > Please review/push.
> 
> Looks good - pushing to autobuild.

Sorry: The patches don't apply.
One thing that caught my eye is that your
patch uses lpcfg_equal_parameter, whereas
current master uses equal_parameter.

Could you point me to more patches that need picking?

I need an update which of your various patchsets are
still missing review.

Thanks - Michael

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 215 bytes
Desc: Digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140129/bc40fc0b/attachment.pgp>


More information about the samba-technical mailing list